Thread: Nasty Read Message Bug

Nasty bug in messages_inbox.php allowing reading of any message on the site.

messages_inbox.php

Code:

$message_sql= "SELECT m.`Text`, m.`Subject`, DATE_FORMAT( m.`Date`, '$short_date_format' ) AS `Date`, p.Status FROM `Messages` AS m LEFT JOIN Profiles AS p ON m.Sender = p.ID  WHERE m.`ID` = '$messageID'";// AND`Sender` = '$senderID'";

replace with

Code:

$message_sql= "SELECT m.`Text`, m.`Subject`, DATE_FORMAT( m.`Date`, '$short_date_format' ) AS `Date`, p.Status FROM `Messages` AS m LEFT JOIN Profiles AS p ON m.Sender = p.ID  WHERE m.`ID` = '$messageID' AND `Recipient` = '$memberID'";

This bug is in 6.0.0, 6.0.1, 6.0.2 and CLEAN 6.0.1

I assume BoonEx will apply the fix to 6.0.3 - but in any case, we will apply it to our CLEAN projects.

Rob

Mass mail sent to all ModMySite users:

Hello All,

For those of you running Dolphin 6.0.0, 6.0.1, 6.0.1 CLEAN, or 6.0.2, a very nasty read message bug has been discovered where users can read any message on the system.

We have posted a easy fix here in this thread:

http://www.modmysite.com/showthread....8557#post28557

To protect your users privacy, and your site reputation with your users, you should seriously consider applying this fix.

If you need any help applying this fix, or need help with any other aspect of your Dolphin or aeDating site, please do not hesitate to contact us.

Warm regards,

Rob LeVine
support@modmysite.com
518-632-4152

Great - please test the quick fix - and get back to me if there are any issues related to it.

Smoge

BoonEx applied this fix to 6.0.3 - and left an easter egg for me. LOL!

// Did you find me, Smoge? I see you...

Code:

	$message_sql= "SELECT m.`Text`, m.`Subject`, DATE_FORMAT( m.`Date`, '$short_date_format' ) AS `Date`, p.Status FROM `Messages` AS m LEFT JOIN Profiles AS p ON m.Sender = p.ID  WHERE m.`ID` = '$messageID' AND `Recipient` = '$memberID'"; // Did you find me, Smoge? I see you...