Thread: Rate Photo Private Photo bug

OK...

I was just notified about this..
If a member marks a photo as private it still shows up in rate photo....
Not good...


Anyone one else have this problem or tested it.
I went to my test site and this is a confirmed bug for 4.1.2.


The only reason I know about this is because a new member marked some photos a private and was not very happy to see their pics on the rate photo page......

If you have not tried this I would.. (does it ever end with this poor code?)

Here is the section of rate.php

Code:

// get random picture =============================================================================================
if ( strlen($_POST['showme']) && $_POST['showme'] != 'all' )
{
    if ( $_POST['showme'] == 'couple' )
        $sex_part = "AND ProfileType = 'couple'";
    else
        $sex_part = "AND Sex = '". process_db_input($_POST['showme']) ."' AND ProfileType != 'couple'";
}
else
    $sex_part = "";
 
$c = 0;
$select_part = ", Pic_0_addon";
$where_part = "AND (0 ";
for ($c = 1; $c <= $pic_num; $c++)
{
$select_part .= ", Pic_${c}_addon";
$where_part .= "OR Pic_${c}_addon <> '0' AND Pic_${c}_addon <> '' AND LEFT(Pic_${c}_addon,1) <> 'p' ";
}
$where_part .= ")";
 
$query = "SELECT ID, NickName, Headline $select_part FROM Profiles WHERE Status = 'Active' $where_part $sex_part ORDER BY RAND()";

Although it looks like this should filter for private photos it does not.
I looked in my database and photos marked as private ex p1234 or p8989 are showing up in rate photos..

I suspect it has something to do with this

Code:

LEFT(Pic_${c}_addon,1) <> 'p'

Any Ideas Smoge?


Peace.

Todd

Todd,

I just ran ours and it does the same thing, the private photos show in the rate feature as well. Version 4.1 patch 0004

Any Ideas Smoge?

Right - the p in the photo database entry indicates it is private.

I have not looked at or troubleshot this code - but it appears you are looking in the right direction.